From 8aa31d03b1b81207d1e121abfcf7907da449ffa7 Mon Sep 17 00:00:00 2001 From: wphan Date: Sun, 4 Aug 2024 14:25:30 +0200 Subject: [PATCH 1/2] limit the endpoints to measure response times for --- src/core/middleware.ts | 17 ++++++++++++----- src/index.ts | 2 +- src/serverLite.ts | 2 +- src/utils/constants.ts | 9 +++++++++ 4 files changed, 23 insertions(+), 7 deletions(-) create mode 100644 src/utils/constants.ts diff --git a/src/core/middleware.ts b/src/core/middleware.ts index 7705d3c..e17f319 100644 --- a/src/core/middleware.ts +++ b/src/core/middleware.ts @@ -4,14 +4,21 @@ import { endpointResponseTimeHistogram, responseStatusCounter, } from './metrics'; +import { MEASURED_ENDPOINTS } from '../utils/constants'; -export const handleResponseTime = responseTime( - (req: Request, res: Response, time: number) => { +export const handleResponseTime = ( + measuredEndpoints: string[] = MEASURED_ENDPOINTS +) => { + return responseTime((req: Request, res: Response, time: number) => { const endpoint = req.path; - if (endpoint === '/health' || req.url === '/') { + console.log(endpoint); + if (!measuredEndpoints.includes(endpoint)) { return; } + //if (endpoint === '/health' || req.url === '/') { + // return; + //} responseStatusCounter.add(1, { endpoint, @@ -22,5 +29,5 @@ export const handleResponseTime = responseTime( endpointResponseTimeHistogram.record(responseTimeMs, { endpoint, }); - } -); + }); +}; diff --git a/src/index.ts b/src/index.ts index 2d0b8d5..b4cc151 100644 --- a/src/index.ts +++ b/src/index.ts @@ -90,7 +90,7 @@ app.use(cors({ origin: '*' })); app.use(compression()); app.set('trust proxy', 1); app.use(logHttp); -app.use(handleResponseTime); +app.use(handleResponseTime()); // strip off /dlob, if the request comes from exchange history server LB app.use((req, _res, next) => { diff --git a/src/serverLite.ts b/src/serverLite.ts index 4fdc7d3..5ab19af 100644 --- a/src/serverLite.ts +++ b/src/serverLite.ts @@ -65,7 +65,7 @@ app.use(cors({ origin: '*' })); app.use(compression()); app.set('trust proxy', 1); app.use(logHttp); -app.use(handleResponseTime); +app.use(handleResponseTime()); // strip off /dlob, if the request comes from exchange history server LB app.use((req, _res, next) => { diff --git a/src/utils/constants.ts b/src/utils/constants.ts new file mode 100644 index 0000000..04eddd6 --- /dev/null +++ b/src/utils/constants.ts @@ -0,0 +1,9 @@ +export const MEASURED_ENDPOINTS = [ + '/priorityFees', + '/batchPriorityFees', + '/topMakers', + '/l2', + '/batchL2', + '/batchL2Cache', + '/l3', +]; From 94c8aaf1d81cdced861e937b8b3fe85ce625b8a5 Mon Sep 17 00:00:00 2001 From: Jack Waller Date: Mon, 5 Aug 2024 14:29:11 +1000 Subject: [PATCH 2/2] chore: remove log --- src/core/middleware.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/middleware.ts b/src/core/middleware.ts index e17f319..98ca918 100644 --- a/src/core/middleware.ts +++ b/src/core/middleware.ts @@ -12,7 +12,6 @@ export const handleResponseTime = ( return responseTime((req: Request, res: Response, time: number) => { const endpoint = req.path; - console.log(endpoint); if (!measuredEndpoints.includes(endpoint)) { return; }