From 40d90418ca8a7007e1b88b4c4789eed39ad81e87 Mon Sep 17 00:00:00 2001 From: wphan Date: Fri, 18 Aug 2023 11:09:40 -0400 Subject: [PATCH] bump sdk, fix double sending headers on error --- package.json | 2 +- src/index.ts | 6 ++++-- yarn.lock | 8 ++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index a9e680b..dc41043 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "main": "lib/index.js", "license": "Apache-2.0", "dependencies": { - "@drift-labs/sdk": "v2.35.1-beta.6", + "@drift-labs/sdk": "2.37.1-beta.5", "@opentelemetry/api": "^1.1.0", "@opentelemetry/auto-instrumentations-node": "^0.31.1", "@opentelemetry/exporter-prometheus": "^0.31.0", diff --git a/src/index.ts b/src/index.ts index d31bf9f..c536a83 100644 --- a/src/index.ts +++ b/src/index.ts @@ -76,8 +76,10 @@ const logHttp = morgan(logFormat, { }); function errorHandler(err, _req, res, _next) { - logger.error(err.stack); - res.status(500).send('Internal error'); + logger.error(`errorHandler, message: ${err.message}, stack: ${err.stack}`); + if (!res.headersSent) { + res.status(500).send('Internal error'); + } } const app = express(); diff --git a/yarn.lock b/yarn.lock index 1788148..c0c80f7 100644 --- a/yarn.lock +++ b/yarn.lock @@ -80,10 +80,10 @@ enabled "2.0.x" kuler "^2.0.0" -"@drift-labs/sdk@v2.35.1-beta.6": - version "2.35.1-beta.6" - resolved "https://registry.yarnpkg.com/@drift-labs/sdk/-/sdk-2.35.1-beta.6.tgz#1cf90fc0586da97c9a2bf106bcc04a25b0a2865f" - integrity sha512-05vobfxFG+z5sTQFIO+mHuAuz0Eut5tTeNZbOfl1ff/vlHNu/hyAUJ8gMVuE6N1kBHDLBVVPhVRQ2sQn0x0HUw== +"@drift-labs/sdk@2.37.1-beta.5": + version "2.37.1-beta.5" + resolved "https://registry.yarnpkg.com/@drift-labs/sdk/-/sdk-2.37.1-beta.5.tgz#6f3dfc8b4bc7d5794b3891a61b5e90db215f4fcc" + integrity sha512-HR4QFBCyQ+BxAClGldhrtnxfRGZaKdz7t6Su03qAJunMlz4b/choKJoZHAECE5cEyO9nSoeSiBBdABjcShH51A== dependencies: "@coral-xyz/anchor" "0.26.0" "@ellipsis-labs/phoenix-sdk" "^1.4.2"